Accessors

  • 24.1 Accessor functions for properties are not required.

  • 24.2 Do not use JavaScript getters/setters as they cause unexpected side effects and are harder to test, maintain, and reason about. Instead, if you do make accessor functions, use getVal() and setVal('hello').

    1. // bad
    2. class Dragon {
    3.   get age() {
    4.     // ...
    5.   }
    7.   set age(value) {
    8.     // ...
    9.   }
    10. }
    12. // good
    13. class Dragon {
    14.   getAge() {
    15.     // ...
    16.   }
    18.   setAge(value) {
    19.     // ...
    20.   }
    21. }

  • 24.3 If the property/method is a boolean, use isVal() or hasVal().

    1. // bad
    2. if (!dragon.age()) {
    3.   return false;
    4. }
    6. // good
    7. if (!dragon.hasAge()) {
    8.   return false;
    9. }

  • 24.4 It’s okay to create get() and set() functions, but be consistent.

    1. class Jedi {
    2.   constructor(options = {}) {
    3.     const lightsaber = options.lightsaber || 'blue';
    4.     this.set('lightsaber', lightsaber);
    5.   }
    7.   set(key, val) {
    8.     this[key] = val;
    9.   }
    11.   get(key) {
    12.     return this[key];
    13.   }
    14. }